Match render-review verifier to Forgejo run API #17

Merged
agent merged 1 commit from feature/promotion-run-api-shape-1007 into dev 2026-10-07 03:48:30 +03:00
Collaborator

Summary

Validate render-review runs against the actual Forgejo v16 Actions API fields: exact workflow_id and title, trigger_event, prettyref, commit_sha, exact run ID, and parsed dispatch event_payload ref/source input. The legacy event is empty in the live API and is not used as a fallback.

Accept Forgejo's run-scoped artifact list response and workflow_run: null, while preserving exact artifact ID/name, size, expiry and manifest checks. List responses at the page limit or incomplete wrapped responses fail closed.

Verification

  • Pinned test-fetch-promotion-render-review.py: 9/9 passed.
  • Pinned Python compilation: passed.
  • Fixtures model run 1092 fields, empty event, list-shaped artifact response and null nested relation; negative cases cover missing/mismatched workflow, title, trigger, ref, source, SHA, run ID and status.
  • git diff --check: passed.

No release or publication actions are included.

## Summary Validate render-review runs against the actual Forgejo v16 Actions API fields: exact `workflow_id` and title, `trigger_event`, `prettyref`, `commit_sha`, exact run ID, and parsed dispatch `event_payload` ref/source input. The legacy `event` is empty in the live API and is not used as a fallback. Accept Forgejo's run-scoped artifact list response and `workflow_run: null`, while preserving exact artifact ID/name, size, expiry and manifest checks. List responses at the page limit or incomplete wrapped responses fail closed. ## Verification - Pinned `test-fetch-promotion-render-review.py`: 9/9 passed. - Pinned Python compilation: passed. - Fixtures model run 1092 fields, empty event, list-shaped artifact response and null nested relation; negative cases cover missing/mismatched workflow, title, trigger, ref, source, SHA, run ID and status. - `git diff --check`: passed. No release or publication actions are included.
Match render review verifier to Forgejo run API
All checks were successful
Feature branch tests and syntax checks / source-checks (push) Successful in 5m33s
d961c9cbc6
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
danil/bip-max-watch-faces!17
No description provided.